Fix error handling for initial delta snapshot #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-s-rao
added
needs/review
shreyas-s-rao
requested review from
georgekuruvillak and
swapnilgm
as code owners
gardener-robot-ci-1
added
reviewed/ok-to-test
amshuman-kr
reviewed
Jun 7, 2019
swapnilgm
suggested changes
Jun 10, 2019
shreyas-s-rao
force-pushed
the
fix/initial-delta-error-handling
branch
from
bbed3e5 to
02e74a7
Compare
|
@swapnilgm @amshuman-kr I have addressed the review comments. PTAL. |
amshuman-kr
approved these changes
Jun 10, 2019
swapnilgm
reviewed
Jun 11, 2019
Signed-off-by: Shreyas Rao <[email protected]>
shreyas-s-rao
force-pushed
the
fix/initial-delta-error-handling
branch
from
02e74a7 to
36bd479
Compare
|
@swapnilgm I've addressed the review comment. PTAL. |
swapnilgm
added
reviewed/lgtm
gardener-robot-ci-1
added
needs/ok-to-test
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shreyas Rao [email protected]
What this PR does / why we need it:
This PR fixes the error handling while taking initial delta snapshot. Currently, if the initial delta snapshot fails, we retry the etcd probe and try taking the initial delta snapshot again, repeatedly until it succeeds. In the case where backup sidecar had already taken some snapshots and then stopped for some time while etcd is still running and is also compacted in that interval, when sidecar starts again, there's a chance the watch for initial delta snapshot will fail because the latest revision from the snapstore is not available anymore on etcd (as it was compacted). This throws backup sidecar into an infinite failure loop.
This PR fixes this behavior by taking a full snapshot on an initial delta snapshot error, instead of retrying delta snapshot again. Error handling for the full snapshot is as expected, ie, it will be retried after subsequent etcd probe.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: