Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent reduntant frontmatter property: "title" #117

Merged
merged 1 commit into from
Nov 17, 2020
Merged

prevent reduntant frontmatter property: "title" #117

merged 1 commit into from
Nov 17, 2020

Conversation

swilen-iwanow
Copy link
Contributor

@swilen-iwanow swilen-iwanow commented Nov 17, 2020 •
edited by g-pavlov
Loading

What this PR does / why we need it:
Currently the implementation merges frontmatter defined inside the node and the document.
Which issue(s) this PR fixes:
Fixes #116

Special notes for your reviewer:

Release note:

If both document and a node referencing it as source define front-matter, they will be merged and where there are conflicting keys the node front-matter has priority.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 17, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 17, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 17, 2020
g-pavlov
g-pavlov approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@g-pavlov g-pavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 17, 2020
@gardener-robot gardener-robot added size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 17, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 17, 2020
@swilen-iwanow swilen-iwanow merged commit ba902e3 into master Nov 17, 2020
@swilen-iwanow swilen-iwanow deleted the fm branch November 17, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-pavlov g-pavlov g-pavlov approved these changes

Assignees

@swilen-iwanow swilen-iwanow

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent redundant title front-matter property
4 participants
@swilen-iwanow @g-pavlov @gardener-robot-ci-1 @gardener-robot