Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent redundant title front-matter property #116

Closed
g-pavlov opened this issue Nov 17, 2020 · 0 comments · Fixed by #117
Closed

Prevent redundant title front-matter property #116

g-pavlov opened this issue Nov 17, 2020 · 0 comments · Fixed by #117
Assignees
Labels
kind/enhancement Enhancement, improvement, extension priority/2 Priority (lower number equals higher priority)

Comments

@g-pavlov
Copy link
Contributor

What would you like to be added:
Use the document front matter if it is available and the node-defined front matter only if it is not in preparation for a more thorough implementation with merge strategies.

Why is this needed / describe a real-world scenario:
If there is front matter in a document and in the node that has source referencing this document, currently it is concatenated as two sequential byte data streams and that leads to potentially redundant properties.

How to categorize this?:
/kind enhancement
/priority critical

@g-pavlov g-pavlov added the kind/enhancement Enhancement, improvement, extension label Nov 17, 2020
@gardener-robot gardener-robot added the priority/critical Needs to be resolved soon, because it impacts users negatively label Nov 17, 2020
@gardener-robot gardener-robot added priority/2 Priority (lower number equals higher priority) and removed priority/critical Needs to be resolved soon, because it impacts users negatively labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension priority/2 Priority (lower number equals higher priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants