Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Allow scaling down of machine with already lowered priority #75

Merged
merged 1 commit into from
May 4, 2021
+0 −3
Merged

Bugfix: Allow scaling down of machine with already lowered priority #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions cluster-autoscaler/cloudprovider/mcm/mcm_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,9 +797,6 @@ func isMachineTerminating(machine *v1alpha1.Machine) bool {
if !machine.GetDeletionTimestamp().IsZero() {
klog.Infof("Machine %q is already being terminated, and hence skipping the deletion", machine.Name)
return true
} else if machine.Annotations != nil && machine.Annotations[machinePriorityAnnotation] == "1" {
klog.Infof("Machine %q 's priority is set to 1, we assume it to be triggered for deletion by autoscaler earlier, hence skipping deletion", machine.Name)
return true
}
return false
}