Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Allow scaling down of machine with already lowered priority #75

Conversation

prashanth26
Copy link

@prashanth26 prashanth26 commented May 4, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #64

Special notes for your reviewer:
Please check the issue. The fix in line with changes suggested by @hardikdr

Release note:

Bug fix: Allow scaling down of machine with already lowered priority

/assign @AxiomSamarth

@prashanth26 prashanth26 requested a review from hardikdr as a code owner May 4, 2021 03:49
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 4, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 4, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 4, 2021
@prashanth26 prashanth26 changed the title Bugfix: Allow scaling-down of machine with already lowered priority Bugfix: Allow scaling down of machine with already lowered priority May 4, 2021
@AxiomSamarth
Copy link

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 4, 2021
@prashanth26 prashanth26 merged commit d1baa2a into gardener:machine-controller-manager-provider May 4, 2021
@prashanth26 prashanth26 deleted the bugfix/allow-deletion-of-lower-prio branch May 4, 2021 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow deletion of the machines with already lowered priority.
5 participants