This repository has been archived by the owner on Dec 14, 2023. It is now read-only.
Support CPU topology and resource limits #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfranczy
changed the title
gardener-robot-ci-1
added
the
reviewed/ok-to-test
mfranczy
added
the
reviewed/do-not-merge
|
still testing the PR |
gardener-robot-ci-2
added
needs/ok-to-test
mfranczy
commented
Oct 6, 2020
pkg/kubevirt/apis/provider_spec.go
Outdated
| // SourceURL is the HTTP URL of the source image imported by CDI. | ||
| SourceURL string `json:"sourceURL,omitempty"` | ||
| // StorageClassName is the name which CDI uses to in order to create claims. | ||
| // +optional |
There was a problem hiding this comment.
remove all `+optional' as there is no code generator
There was a problem hiding this comment.
I would suggest to keep them, for documentation purposes, and ensure that they are placed correctly.
stoyanr
suggested changes
Oct 6, 2020
pkg/kubevirt/apis/provider_spec.go
Outdated
| // SourceURL is the HTTP URL of the source image imported by CDI. | ||
| SourceURL string `json:"sourceURL,omitempty"` | ||
| // StorageClassName is the name which CDI uses to in order to create claims. | ||
| // +optional |
There was a problem hiding this comment.
I would suggest to keep them, for documentation purposes, and ensure that they are placed correctly.
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
mfranczy
commented
Oct 7, 2020
| @@ -16,21 +16,20 @@ package api | |||
|
|
|||
| import ( | |||
| corev1 "k8s.io/api/core/v1" | |||
| "k8s.io/apimachinery/pkg/api/resource" | |||
| kubevirtv1 "kubevirt.io/client-go/api/v1" | |||
| ) | |||
|
|
|||
| // KubeVirtProviderSpec is the spec to be used while parsing the calls. | |||
| type KubeVirtProviderSpec struct { | |||
There was a problem hiding this comment.
@stoyanr I didn't touch Region and Zone since you've created a PR about that.
|
/lgtm There are some linter errors (run |
stoyanr
approved these changes
Oct 7, 2020
Signed-off-by: Marcin Franczyk <[email protected]>
gardener-robot-ci-1
added
the
reviewed/ok-to-test
|
@stoyanr fixed, I've added validation for |
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
mfranczy
removed
the
reviewed/do-not-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marcin Franczyk [email protected]
What this PR does / why we need it:
supports CPU topology and resource limits
Which issue(s) this PR fixes:
Fixes gardener-attic/gardener-extension-provider-kubevirt#36
Special notes for your reviewer:
Release note: