Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional VM configuration options #36

Assignees
Labels
area/performance Performance (across all domains, such as control plane, networking, storage, etc.) related kind/enhancement Enhancement, improvement, extension platform/kubevirt Container Native Virtualization (CNV) KubeVirt platform/infrastructure priority/3 Priority (lower number equals higher priority)

Comments

@stoyanr
Copy link
Contributor

stoyanr commented Sep 4, 2020

Currently it's already possible to specify essential VM parameters such as CPUs, memory, disk size, and storage class for the VM disk. We should be able to specify also additional VM parameters, usually for an enhanced VM performance. These could include, among others:

We should discuss what additional parameters should be added, and how should they be configured. The options are:

  • In the spec.providerConfig section of the cloud profile, if to configure machine types shared between multiple shoots
  • In the provider.workers[n].providerConfig section of the shoot resource, to configure individual shoots.

/area performance
/kind enhancement
/priority normal
/platform kubevirt

@gardener-robot gardener-robot added area/performance Performance (across all domains, such as control plane, networking, storage, etc.) related kind/enhancement Enhancement, improvement, extension platform/kubevirt Container Native Virtualization (CNV) KubeVirt platform/infrastructure priority/normal labels Sep 4, 2020
@stoyanr
Copy link
Contributor Author

stoyanr commented Sep 4, 2020

/cc @mfranczy Feel free to add your ideas and comments

@mfranczy
Copy link
Contributor

mfranczy commented Sep 14, 2020

Overall we should support:

- [ ] support for VM run strategies https://kubevirt.io/user-guide/#/creation/run-strategies

- [ ] set liveness and readiness probes https://kubevirt.io/user-guide/#/creation/probes

@mfranczy
Copy link
Contributor

/assign @mfranczy

@mfranczy
Copy link
Contributor

@stoyanr @moadqassem we have to discuss how we want to support requests and limits in terms of specified resources. Currently in a machineType object we can only set requested resources, the question is how we want to handle limits.
Let's discuss this on our daily sync.

@mfranczy
Copy link
Contributor

mfranczy commented Oct 8, 2020

@stoyanr I removed support for RunStrategy and probes, giving this a second thought, since MCM has a timeout for machine to join nodes that would bring another complexity level for MCM-provider-kubevirt which is not needed.

The only left things are disks performance settings and validator which I am working on now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance Performance (across all domains, such as control plane, networking, storage, etc.) related kind/enhancement Enhancement, improvement, extension platform/kubevirt Container Native Virtualization (CNV) KubeVirt platform/infrastructure priority/3 Priority (lower number equals higher priority)
Projects
None yet
3 participants