This repository has been archived by the owner on Nov 9, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/quality
Output qualification (tests, checks, scans, automation in general, etc.) related
area/robustness
Robustness, reliability, resilience related
area/scalability
Scalability related
kind/enhancement
Enhancement, improvement, extension
priority/normal
needs/review
Needs review
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
needs/second-opinion
Needs second review by someone else
labels
Dec 2, 2020
gardener-robot-ci-2
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Dec 2, 2020
Also tested this PR in my local gardener setup, shoot creation/reconciliation/hibernation/wakeup/deletion works fine. |
/assign |
timuthy
suggested changes
Dec 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR. Now it looks very similar to what we do in the Gardener extension which will further simplify maintenance, thanks for that. I only found one nit for now.
timebertt
force-pushed
the
enh/target-client
branch
from
December 4, 2020 07:44
cf4b18e
to
ff5bb22
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Dec 4, 2020
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Dec 4, 2020
timebertt
force-pushed
the
enh/target-client
branch
from
December 4, 2020 12:54
ff5bb22
to
ca3caf6
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Dec 4, 2020
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Dec 4, 2020
timuthy
approved these changes
Dec 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
gardener-robot
added
needs/changes
Needs (more) changes
and removed
needs/changes
Needs (more) changes
needs/review
Needs review
needs/second-opinion
Needs second review by someone else
reviewed/lgtm
Has approval for merging
labels
Dec 4, 2020
This was referenced Dec 7, 2020
gardener-robot
added
priority/3
Priority (lower number equals higher priority)
and removed
priority/3
Priority (lower number equals higher priority)
labels
Mar 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area/quality
Output qualification (tests, checks, scans, automation in general, etc.) related
area/robustness
Robustness, reliability, resilience related
area/scalability
Scalability related
kind/enhancement
Enhancement, improvement, extension
needs/changes
Needs (more) changes
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area scalability robustness quality
/kind enhancement
/priority normal
What this PR does / why we need it:
This PR improves the following aspects of the client for the target cluster:
--target-disable-cache
. In this case, grm won't cache any objects of the target cluster and always talk to the target API server directly (fixes Add option to disable target cache #92).DynamicRESTMapper
, which will ensure that resources are rediscovered onNoMatchErrors
, but discovery calls are not executed more than once every 10 minutes (fixes Switch to DynamicRESTMapper for target client #93).I took the chance to refactor the contents of
app.go
, as I found it to be very overloaded and hard to comprehend.Now
add.go
ClassFilter
logic is moved into its own dedicated packagecmd
app.go
only instruments those options andAddToManager
functions to put everything together. This is very similar to how we construct manager, options and controllers in our extensions.Also, I switched to our gcr copies of the base images.
Special notes for your reviewer:
Similar to g/g, grm now also vendors our c-r fork in order to get the fix from kubernetes-sigs/controller-runtime#1151:
sigs.k8s.io/controller-runtime => github.com/gardener/controller-runtime v0.6.3-gardener.1
We can drop it, once we have upgraded to [email protected].
Release note: