Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Switch to DynamicRESTMapper for target client #93

Closed
timebertt opened this issue Nov 30, 2020 · 1 comment · Fixed by #95
Closed

Switch to DynamicRESTMapper for target client #93

timebertt opened this issue Nov 30, 2020 · 1 comment · Fixed by #95
Assignees
@timebertt
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related area/scalability Scalability related kind/cleanup Something that is not needed anymore and can be cleaned up kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority)

Comments

@timebertt
Copy link
Contributor

timebertt commented Nov 30, 2020 •
edited
Loading

How to categorize this issue?

/area scalability
/kind cleanup
/priority normal

What would you like to be added:

With the recent improvements in controller-runtime (kubernetes-sigs/controller-runtime#1151), we can/should replace the DeferredDiscoveryRESTMapper by a DynamicRESTMapper to avoid explicit rediscovery.

https://github.com/gardener/gardener-resource-manager/blob/827ae66273760c834b2dcf34459d8cf2fca5a387/pkg/controller/managedresources/controller.go#L463-L468

This way, grm immediately rediscovers resources if some of them are not known (yet), so that no extra reconciliation is needed.
It will still adhere to the specified rate limits, so we don't do unnecessary extraneous discovery calls (even across managed resources - which wasn't the case before).
@timebertt timebertt added the kind/enhancement Enhancement, improvement, extension label Nov 30, 2020
@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up priority/normal labels Nov 30, 2020
@timebertt
Copy link
Contributor Author

/assign

@gardener-robot gardener-robot added the area/scalability Scalability related label Dec 2, 2020
@timebertt timebertt mentioned this issue Dec 2, 2020
Merged
@gardener-robot gardener-robot added the priority/3 Priority (lower number equals higher priority) label Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@timebertt timebertt

Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related area/scalability Scalability related kind/cleanup Something that is not needed anymore and can be cleaned up kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Target client improvements timebertt/gardener-resource-manager
2 participants
@timebertt @gardener-robot