Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Alert get dismissed in the admin/alerts page #2569

Merged
merged 6 commits into from
Dec 5, 2022

Conversation

flacial
Copy link
Member

@flacial flacial commented Dec 5, 2022

Closes #2269

Description

After the recent changes to the <Alert /> component, the alerts in the admin/alerts page can be dismissed. As it's not a desirable thing, this PR aims at removing the ability to dismiss them.

Before

With dismiss image

After

Without dismiss image

@vercel
Copy link

vercel bot commented Dec 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
c0d3-app ✅ Ready (Inspect) Visit Preview Dec 5, 2022 at 11:39AM (UTC)

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #2569 (c861763) into master (1d93ed1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2569   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          186       186           
  Lines         3389      3389           
  Branches       910       910           
=========================================
  Hits          3389      3389           
Impacted Files Coverage Δ
components/admin/alerts/AdminNewAlert.tsx 100.00% <ø> (ø)
pages/admin/alerts.tsx 100.00% <ø> (ø)

@flacial flacial merged commit d2c09fb into master Dec 5, 2022
@flacial flacial deleted the 2269-alert-get-dismissed-in-the-adminalerts-page branch December 19, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alert get dismissed in the admin/alerts page
2 participants