fix: Alert can't be dismissed #2216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report
@@ Coverage Diff @@
## master #2216 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 173 173
Lines 2948 2951 +3
Branches 794 796 +2
=========================================
+ Hits 2948 2951 +3
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SlyBouhafs
approved these changes
Aug 28, 2022
HS-90
approved these changes
Aug 28, 2022
| variant={`${type === 'urgent' ? 'danger' : 'primary'}`} | ||
| onClose={() => { | ||
| setShow(false) | ||
| onDismiss && onDismiss(id) |
There was a problem hiding this comment.
Just out of curiosity and to confirm, does onDismiss handle whether or not the alert will be displayed for particular user in the future(if the user clicks the x button to dismiss)?
It appears the frontend is handled by setShow
There was a problem hiding this comment.
No, it doesn't handle it. It gets called when the alert is closed. It's useful when we want to perform a certain action when the alert closes.
songz
approved these changes
Aug 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2215
Problem
The Alert component can't be dismissed through clicking the close button.
Solution
Replace its implementation with react-bootstrap alert component.