kernel: move NrErrLine from GAPState to TypInputFile #4131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: kernel
release notes: not needed
fingolfin
force-pushed
the
mh/scanner-struct
branch
from
58e9dd7
to
b6ab370
Compare
fingolfin
force-pushed
the
mh/scanner-struct
branch
from
b6ab370
to
13ce9fd
Compare
wilfwilson
approved these changes
Oct 15, 2020
|
I'm pretty sure that the conflict comes from my typo PR #4139, but you'd already fixed the mistake in this PR, so your change should win the conflict. |
Also reformat and update some code comments
fingolfin
force-pushed
the
mh/scanner-struct
branch
from
13ce9fd
to
9607ca7
Compare
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes PR #4122 which should be reviewed and merged first.DONE