kernel: remove input stream stack #4122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: kernel
release notes: not needed
fingolfin
force-pushed
the
mh/remove-input-stack
branch
2 times, most recently
from
ab471e2
to
e24bfda
Compare
fingolfin
force-pushed
the
mh/remove-input-stack
branch
3 times, most recently
from
74729a4
to
274c391
Compare
This was referenced Oct 10, 2020
|
Maybe mention in the commit message we are removing the (apparently unused) ToggleEcho? I guess at some point someone wanted it -- no need to mention it in the release notes. |
ChrisJefferson
approved these changes
Oct 12, 2020
fingolfin
force-pushed
the
mh/remove-input-stack
branch
from
274c391
to
ae0c5c1
Compare
Instead of pre-allocating a fixed number of TypInputFile instances on each thread, we allocate the required storage dynamically on the stack. This arguably makes it easier to reason about the global state of GAP. It also enables future simplifications and improvements, e.g. further decoupling the input file code from the line buffering and potential optimizations resulting from that.
|
Aha, good point, I forgot about the removal of |
fingolfin
force-pushed
the
mh/remove-input-stack
branch
from
ae0c5c1
to
47dbd66
Compare
|
I've added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of pre-allocating a fixed number of TypInputFile instances on each
thread, we allocate the required storage dynamically on the stack. This
arguably makes it easier to reason about the global state of GAP.
It also enables future simplifications and improvements, e.g. further
decoupling the input file code from the line buffering and potential
optimizations resulting from that.
Next step: minimize or ideally eliminate usage of
IO()->Inputresp.GetCurrentInput.