ObjectifyWithAttributes: return the new object #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
force-pushed
the
mh/ObjectifyWithAttributes
branch
from
64d64a7
to
d5e14fd
Compare
Codecov Report
@@ Coverage Diff @@
## master #2098 +/- ##
==========================================
- Coverage 69.22% 61.73% -7.5%
==========================================
Files 489 489
Lines 256253 256988 +735
==========================================
- Hits 177395 158651 -18744
- Misses 78858 98337 +19479
|
markuspf
approved these changes
Jan 24, 2018
fingolfin
changed the title
|
@fingolfin Agree for this to go to stable-4.9 |
|
Ah, sorry, forgot to adjust the PR title: there used to be additional tweaks, but they caused some test failures I do not understand, so I ripped them out, figuring that it's better to have a minimal fix for this anyway |
|
This PR is already based (on the git side) on stable-4.9, so if people agree it should go into stable-4.9, just retarget the PR via the |
|
Also cherry-picked this into |
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2083
This change could in theory go into stable-4.9.