Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No return value of ObjectifyWithAttributes? #2083

Closed
ThomasBreuer opened this issue Jan 12, 2018 · 1 comment
Closed

No return value of ObjectifyWithAttributes? #2083

ThomasBreuer opened this issue Jan 12, 2018 · 1 comment
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: library
Milestone
GAP 4.9.0

Comments

@ThomasBreuer
Copy link
Contributor

Objectify returns the object it has created.
I find this very convenient.
Is there any reason why ObjectifyWithAttributes does not return the object in question?
@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: library labels Jan 12, 2018
@fingolfin
Copy link
Member

I am pretty sure there is no good reason. My guess would be that this was an oversight -- though @stevelinton would know best, he added the function 1998-08-10 in a commit with message "First (GAP) try at SetMultipleAttributes and ObjectifyWithAttributes".

But even if there was a reason, I don't see one now. A pull request adding return obj; to that function would most likely be merged (perhaps even into stable-4.9, if somebody (you?) wants it badly enough in GAP 4.9)

@fingolfin fingolfin mentioned this issue Jan 21, 2018
Merged
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.9.0 milestone Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: library
Projects
None yet
Milestone
GAP 4.9.0
Development

No branches or pull requests
3 participants
@fingolfin @olexandr-konovalov @ThomasBreuer