Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RandomSource in a few more places #1599

Merged
merged 8 commits into from
Sep 19, 2017
Merged

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Aug 20, 2017

This PR makes some progress on issue #1098.

@fingolfin fingolfin added the kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements label Aug 20, 2017
@codecov
Copy link

codecov bot commented Sep 14, 2017

Codecov Report

Merging #1599 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1599      +/-   ##
==========================================
+ Coverage   64.45%   64.47%   +0.02%     
==========================================
  Files        1003     1002       -1     
  Lines      326890   326805      -85     
  Branches    13216    13239      +23     
==========================================
+ Hits       210696   210708      +12     
+ Misses     113331   113234      -97     
  Partials     2863     2863
Impacted Files Coverage Δ
lib/modfree.gi 78.76% <100%> (ø) ⬆️
lib/random.gi 76.41% <100%> (+0.45%) ⬆️
lib/smgrpfre.gi 74.77% <100%> (+4.86%) ⬆️
hpcgap/lib/zmodnz.gi 93.84% <100%> (ø) ⬆️
hpcgap/lib/random.g 90.47% <100%> (+27.31%) ⬆️
lib/matrix.gi 76.88% <100%> (+0.32%) ⬆️
lib/zmodnz.gi 95.41% <100%> (ø) ⬆️
lib/fieldfin.gi 63.7% <100%> (ø) ⬆️
lib/queue.g 66.4% <0%> (-3.2%) ⬇️
src/vars.h 93.93% <0%> (-3.04%) ⬇️
... and 20 more

@fingolfin
Copy link
Member Author

I rebased this, fixed the test failures (I hope, we'll see when Travis completed) and added the previously missing documentation update for the RandomMat functions.

Hopefully this can be merged soon -- @ChrisJefferson if you have any thoughts on this PR, please ... :-)

@fingolfin
Copy link
Member Author

Turns out initialization of the old-style GlobalRandomSource in HPC-GAP was subtly broken. So I added another commit to fix that, and while at it, also merged hpcgap/lib/random.gi into lib/random.gi. Let's see if tests pass now.

@fingolfin fingolfin merged commit 865690e into gap-system:master Sep 19, 2017
@fingolfin fingolfin deleted the mh/random branch September 26, 2017 00:45
@olexandr-konovalov olexandr-konovalov added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants