lib: add RandomSource support to ZmodnZ Random

gap-system · Sep 14, 2017 · cd9bcbb · cd9bcbb
1 parent a5c084d
commit cd9bcbb
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/lib/zmodnz.gi b/lib/zmodnz.gi
@@ -772,12 +772,12 @@ InstallMethod( AsSSortedList,
 ##
 #M  Random( <R> ) . . . . . . . . . . . . . . . . . method for full ring Z/nZ
 ##
-InstallMethod( Random,
-    "for full ring Z/nZ",
-    [ IsZmodnZObjNonprimeCollection and IsWholeFamily ],
+InstallMethodWithRandomSource(Random,
+    "for a random source and full ring Z/nZ",
+    [ IsRandomSource, IsZmodnZObjNonprimeCollection and IsWholeFamily ],
     RankFilter( IsRing ),
-    R -> ZmodnZObj( ElementsFamily( FamilyObj( R ) ),
-                    Random( [ 0 .. Size( R ) - 1 ] ) ) );
+    { rs, R } -> ZmodnZObj( ElementsFamily( FamilyObj( R ) ),
+                    Random( rs, [ 0 .. Size( R ) - 1 ] ) ) );
 
 
 #############################################################################

diff --git a/tst/testinstall/zmodnz.tst b/tst/testinstall/zmodnz.tst
@@ -431,6 +431,13 @@ matrix over Integers mod 170141183460469231731687303715884105728:
 [ [  92709463147897837085761925410587,  92709463147897837085761925410587 ],
   [  92709463147897837085761925410587,  92709463147897837085761925410587 ] ]
 
+# test the methods for Random
+gap> R := Integers mod 10;;
+gap> Random(R);
+ZmodnZObj( 4, 10 )
+gap> Random(GlobalRandomSource, R);
+ZmodnZObj( 9, 10 )
+
 #
 gap> STOP_TEST( "zmodnz.tst", 1);