Skip to content

Commit

Permalink
Use IsListOrCollection instead of IsCollection in declarations
Browse files Browse the repository at this point in the history
This allows installing methods for "IsList and IsEmpty", which is a list
but not a collection.
  • Loading branch information
fingolfin committed Mar 3, 2018
1 parent dc5bfbe commit 3b375f1
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions lib/grp.gd
Original file line number Diff line number Diff line change
Expand Up @@ -3542,7 +3542,7 @@ DeclareOperation( "GrowthFunctionOfGroup",
##
DeclareOperation( "GroupByGenerators", [ IsCollection ] );
DeclareOperation( "GroupByGenerators",
[ IsCollection, IsMultiplicativeElementWithInverse ] );
[ IsListOrCollection, IsMultiplicativeElementWithInverse ] );


#############################################################################
Expand All @@ -3566,7 +3566,7 @@ DeclareOperation( "GroupByGenerators",
##
DeclareOperation( "GroupWithGenerators", [ IsCollection ] );
DeclareOperation( "GroupWithGenerators",
[ IsCollection, IsMultiplicativeElementWithInverse ] );
[ IsListOrCollection, IsMultiplicativeElementWithInverse ] );


#############################################################################
Expand Down
6 changes: 3 additions & 3 deletions lib/ideal.gd
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ InstallTrueMethod( IsTwoSidedIdealInParent,
## </ManSection>
## <#/GAPDoc>
##
DeclareOperation( "TwoSidedIdealByGenerators", [ IsRing, IsCollection ] );
DeclareOperation( "TwoSidedIdealByGenerators", [ IsRing, IsListOrCollection ] );

DeclareSynonym( "IdealByGenerators", TwoSidedIdealByGenerators );

Expand All @@ -252,7 +252,7 @@ DeclareSynonym( "IdealByGenerators", TwoSidedIdealByGenerators );
## </ManSection>
## <#/GAPDoc>
##
DeclareOperation( "LeftIdealByGenerators", [ IsRing, IsCollection ] );
DeclareOperation( "LeftIdealByGenerators", [ IsRing, IsListOrCollection ] );


#############################################################################
Expand All @@ -275,7 +275,7 @@ DeclareOperation( "LeftIdealByGenerators", [ IsRing, IsCollection ] );
## </ManSection>
## <#/GAPDoc>
##
DeclareOperation( "RightIdealByGenerators", [ IsRing, IsCollection ] );
DeclareOperation( "RightIdealByGenerators", [ IsRing, IsListOrCollection ] );


#############################################################################
Expand Down
4 changes: 2 additions & 2 deletions lib/mapping.gd
Original file line number Diff line number Diff line change
Expand Up @@ -830,7 +830,7 @@ DeclareOperation( "ImagesRepresentative", [ IsGeneralMapping, IsObject ] );
## </ManSection>
## <#/GAPDoc>
##
DeclareOperation( "ImagesSet", [ IsGeneralMapping, IsCollection ] );
DeclareOperation( "ImagesSet", [ IsGeneralMapping, IsListOrCollection ] );


#############################################################################
Expand Down Expand Up @@ -1052,7 +1052,7 @@ DeclareOperation( "PreImagesRepresentative",
## </ManSection>
## <#/GAPDoc>
##
DeclareOperation( "PreImagesSet", [ IsGeneralMapping, IsCollection ] );
DeclareOperation( "PreImagesSet", [ IsGeneralMapping, IsListOrCollection ] );


#############################################################################
Expand Down

0 comments on commit 3b375f1

Please sign in to comment.