Don't rely on hidden impls in certain method installations

gap-system · Mar 3, 2018 · dc5bfbe · dc5bfbe
1 parent 4f82763
commit dc5bfbe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/ghom.gd b/lib/ghom.gd
@@ -273,7 +273,7 @@ InstallAttributeMethodByGroupGeneralMappingByImages :=
             [ IsGroupGeneralMappingByAsGroupGeneralMappingByImages ], 0,
             hom -> attr( AsGroupGeneralMappingByImages( hom ) ) );
     InstallMethod( attr, "get delayed set attribute values", true,
-            [ HasMappingOfWhichItIsAsGGMBI ],
+            [ IsGroupGeneralMapping and HasMappingOfWhichItIsAsGGMBI ],
 	    SUM_FLAGS-1, # we want to do this before doing any calculations
 	    function(hom)
               hom:=MappingOfWhichItIsAsGGMBI( hom );

diff --git a/lib/grppcatr.gi b/lib/grppcatr.gi
@@ -675,7 +675,7 @@ end);
 #M  GeneratorsSmallest(<pcgrp>)
 ##
 InstallMethod(GeneratorsSmallest,"group of pc words which is full family",
-  true, [HasFamilyPcgs],0,
+  true, [IsGroup and HasFamilyPcgs],0,
 function(G)
 local pcgs,gens,U,e,i,j,pa,ros,smallpcgs,exp;