Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAL-285] Fix gnosis safe auth #934

Merged
merged 2 commits into from
Aug 11, 2022
Merged

[GAL-285] Fix gnosis safe auth #934

merged 2 commits into from
Aug 11, 2022

Conversation

Robinnnnn
Copy link
Contributor

@Robinnnnn Robinnnnn commented Aug 9, 2022

  • Account creation
  • Account login

@vercel
Copy link

vercel bot commented Aug 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
gallery ✅ Ready (Inspect) Visit Preview Aug 9, 2022 at 6:31AM (UTC)

@Robinnnnn Robinnnnn marked this pull request as ready for review August 9, 2022 06:30
@Robinnnnn Robinnnnn changed the title Fix gnosis safe auth [GAL-285] Fix gnosis safe auth Aug 9, 2022
Comment on lines +1 to +5
{
"name": "Gallery",
"description": "Share your collection with the world.",
"iconPath": "https://gallery.so/favicon.ico"
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this so that we can be recognized as a "Safe App" by gnosis safe. there's more we can do but this at least gets us over the first step

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! great idea

@kaitoo1
Copy link
Collaborator

kaitoo1 commented Aug 9, 2022

WOO Gnosis is back!! awesome sleuthing

@holic holic merged commit 2be885b into holic/rainbowkit Aug 11, 2022
@holic holic deleted the robin/gnosis-fix branch August 11, 2022 22:57
Robinnnnn added a commit that referenced this pull request Aug 12, 2022
* rainbowkit prototype

* open account modal when already connected

* add notes about rainbowkit customization

* always open connect modal

* split out multichain auth behind a flag

* reworking to conditionally render multichain stuff everywhere based on flag

* dont clear our flag from localstorage

* get signing working

* move over add wallet behavior

* restore metamask check

* normalize error

* Fix broken wagmi build (#933)

* fix ts error

* update nextjs target to experimental-serverless-trace

* update wagmi, typescript, typescript-eslint

* bump sentry

* comment out tests broken by rainbowkit

* downgrade sentry

* [GAL-285] Fix gnosis safe auth (#934)

* manifest

* gnosis support

* supported chains -> supported auth methods

* attempt to add gnosis safe wallet to rainbowkit

does not work

* Revert "attempt to add gnosis safe wallet to rainbowkit"

This reverts commit b5cca4e825d20aef5acec209550634228c47dee1.

* rename old wallet selector for clarity

* copy over gnosis stuff to multichain

* get gnosis button to prompt walletconnect

* maybe a little easier to read

* restore 'more wallets coming soon' message

* remove commented log, clarify others

* missed a spot

* move stuff around to get the provider from the connector

* remove translucent background

* comment out feature flag for now

* activeBlue

* copy change

* add chain logos

* add back in connect-wallet-only conditional for gnosis

* handle cookie error (#943)

Co-authored-by: robin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants