Fix broken wagmi build #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Robinnnnn
commented
Aug 6, 2022
Comment on lines
+1
to
+3
| // TODO: re-enable this after rainbowkit issue is reolved: https://github.com/rainbow-me/rainbowkit/issues/461 | ||
| // unfortunately, mocking the breaking rainbowkit import does not fix the issue | ||
| test('NavActionFollow', () => {}); |
There was a problem hiding this comment.
there's a known issue where rainbowkit is breaking unit tests: rainbow-me/rainbowkit#461
suggested workarounds didn't work, unfortunately
Robinnnnn
commented
Aug 6, 2022
| target: 'serverless', | ||
| target: 'experimental-serverless-trace', |
There was a problem hiding this comment.
fixes the following bug, as suggested by getsentry/sentry-javascript#3575 (comment)
doesn't seem like it'll be a dealbreaker: https://serverless-nextjs.com/docs/inputs/
Robinnnnn
commented
Aug 6, 2022
| "wagmi": "^0.5.12", | ||
| "wagmi": "^0.6.1", |
There was a problem hiding this comment.
main change that fixed initial build issue below; this revealed other issues with sentry:
Robinnnnn
force-pushed
the
robin/fix-broken-wagmi-build
branch
from
46de16b to
aaade8e
Compare
|
🙏 |
Robinnnnn
added a commit
that referenced
this pull request
Aug 12, 2022
* rainbowkit prototype * open account modal when already connected * add notes about rainbowkit customization * always open connect modal * split out multichain auth behind a flag * reworking to conditionally render multichain stuff everywhere based on flag * dont clear our flag from localstorage * get signing working * move over add wallet behavior * restore metamask check * normalize error * Fix broken wagmi build (#933) * fix ts error * update nextjs target to experimental-serverless-trace * update wagmi, typescript, typescript-eslint * bump sentry * comment out tests broken by rainbowkit * downgrade sentry * [GAL-285] Fix gnosis safe auth (#934) * manifest * gnosis support * supported chains -> supported auth methods * attempt to add gnosis safe wallet to rainbowkit does not work * Revert "attempt to add gnosis safe wallet to rainbowkit" This reverts commit b5cca4e825d20aef5acec209550634228c47dee1. * rename old wallet selector for clarity * copy over gnosis stuff to multichain * get gnosis button to prompt walletconnect * maybe a little easier to read * restore 'more wallets coming soon' message * remove commented log, clarify others * missed a spot * move stuff around to get the provider from the connector * remove translucent background * comment out feature flag for now * activeBlue * copy change * add chain logos * add back in connect-wallet-only conditional for gnosis * handle cookie error (#943) Co-authored-by: robin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.