Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal path change needed for galaxy PR 16795 #114

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

sveinugu
Copy link
Contributor

@sveinugu sveinugu commented Oct 26, 2023

Also requires new version 0.0.6 of gx-it-proxy (galaxyproject/gx-it-proxy#17).

Should result in a new release 1.0.4 after merge (as required by galaxyproject/galaxy#16795). @natefoo?

Replaces elixir-oslo#2 which was within my own repo and just stupid! 😅

@sveinugu
Copy link
Contributor Author

sveinugu commented Oct 26, 2023

Status: galaxyproject/gx-it-proxy#17 has been merged, but awaiting version bump to 0.0.6, which I believe depends on galaxyproject/gx-it-proxy#16 (comment). @jmchilton

@sveinugu sveinugu force-pushed the proxy_path_prefix_fix branch from 1267f5a to 66e0891 Compare November 2, 2023 21:20
@sveinugu
Copy link
Contributor Author

sveinugu commented Nov 2, 2023

Ready for review and merge. galaxyproject/gx-it-proxy#17 is merged and v0.0.6 of gx-it-proxy released. @natefoo ?

@sveinugu
Copy link
Contributor Author

sveinugu commented Nov 8, 2023

Ping @natefoo ?

Copy link
Member

@natefoo natefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, thanks for taking care of all the pieces so thoroughly!

@natefoo natefoo merged commit f5f474f into galaxyproject:main Nov 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants