Migrate ItemTags API to FastAPI #17064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
reviewed
Nov 22, 2023
tagged_item_id and tagged_item_tag
arash77
force-pushed
the
migrate_item_tags_fastapi
branch
from
a2ff3b4 to
a10f574
Compare
davelopez
reviewed
Nov 23, 2023
There was a problem hiding this comment.
Very cool indeed! 🚀
Just some minor comments from my side below.
Also, the OpenAPI linting failures seem relevant, and I guess they are somewhat legitimate:
validating _schema.yaml...
[1] _schema.yaml:17120:7 at #/paths/~1api~1histories~1{history_id}~1contents~1{id}~1tags/get/parameters
The operation does not define the path parameter `{history_id}` expected by path `/api/histories/{history_id}/contents/{id}/tags`.
17118 | 'get':
17119 | 'operationId': 'index_api_histories__history_id__contents__id__tags_get'
17120 | 'parameters':
17121 | - 'description': 'history_content_id'
17122 | 'in': 'path'
Error was generated by the path-parameters-defined rule.
Maybe we can do some kind of trick/workaround to fix this using https://fastapi.tiangolo.com/advanced/path-operation-advanced-configuration/#custom-openapi-path-operation-schema? 🤔
mvdbeek
reviewed
Nov 23, 2023
Relocate ItemTags API test
davelopez
approved these changes
Nov 27, 2023
Co-authored-by: David López <[email protected]>
|
This PR was merged without a "kind/" label, please correct. |
nsoranzo
added
kind/enhancement
kind/refactoring
nsoranzo
added a commit
to nsoranzo/galaxy
that referenced
this pull request
Dec 7, 2023
Before galaxyproject#17064 it was possible to create a tag by simply making a POST request like `/api/histories/911dde3ddb677bcd/tags/tag1` , this restores the previous behaviour. Fix BioBlend test failure: https://github.com/galaxyproject/bioblend/actions/runs/7094150509/job/19308900670#step:10:3029
nsoranzo
added a commit
to nsoranzo/galaxy
that referenced
this pull request
Dec 7, 2023
Before galaxyproject#17064 it was possible to create a tag by simply making a POST request like `/api/histories/911dde3ddb677bcd/tags/tag1` , this restores the previous behaviour. Fix BioBlend test failure: https://github.com/galaxyproject/bioblend/actions/runs/7094150509/job/19308900670#step:10:3029
This was referenced Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you do?
lib/galaxy_test/api/ItemTagsAPI logic so all the logic is contained in theItemTagsManagerclassrelated to #10889
Why did you make this change?
This is part of the efforts to migrate the full Galaxy API to FastAPI see #10889.
How to test the changes?
License