Migrate the route "/api/invocations/{invocation_id}" of the workflows API to Fast API #17052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @heisner-tillman, I did not get a closer look at your PR yet but please be aware of potential duplicate effort due to #16707. |
mvdbeek
reviewed
Nov 20, 2023
| FAILED = "failed" | ||
|
|
||
|
|
||
| class EncodedInvocation(BaseModel): |
There was a problem hiding this comment.
Can you name these things {Something}Response ?
mvdbeek
reviewed
Nov 20, 2023
Comment on lines
+193
to
+203
| model_class: str = Field(default=Required, title="Model class", description="Model class name.") | ||
| # TODO - Add proper models | ||
| steps: Optional[List[Dict[str, Optional[str]]]] = None | ||
| inputs: Optional[Dict[str, Dict[str, Optional[str]]]] = None | ||
| input_step_parameters: Optional[Dict[str, Dict[str, Optional[str]]]] = None | ||
| outputs: Optional[Dict[str, Dict[str, Optional[str]]]] = None | ||
| output_collections: Optional[Dict[str, Dict[str, Optional[str]]]] = None | ||
| output_values: Optional[Dict[str, Optional[str]]] = None | ||
| # TODO understand where this comes from | ||
| message: Optional[str] = Field( | ||
| default=None, title="Message", description="Message associated with this invocation." |
There was a problem hiding this comment.
Are these really optional, or is it just that they can be null ? That's not the same
|
To avoid duplication, this work will be continued in collaboration with @martenson on his pull request #16707! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of #10889.
Summary
How to test the changes?
You can find the interactive API documentation here: http://127.0.0.1:8080/api/docs#/workflows/show_invocation_api_invocations__invocation_id__get
License