-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate cloud API to Fast API #16296
Conversation
I have not written any tests for this yet as I do not have cloud-based storage. |
Are you planning to do more routes ? I think it'd be good to coordinate a little, this route for instance we should probably deprecate. |
@mvdbeek we are planning to migrate a few more routes yes. Can we use the meta issue to track which ones are needed and which not? |
@mvdbeek I was planning to try my hand at the old users routes next. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice first try! 👍
I guess the important part here is to have the routes marked as deprecated in the interactive docs, but we should try to keep the same response models while they are still part of the API.
This is a part of #10889.
Summary
How to test the changes?
You can find the interactive API documentation here: http://127.0.0.1:8080/api/docs#/cloud
License