This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 794
refactor(solc): rewrite compiler passes and cache change detection #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
reviewed
Jan 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so far so good-really like the direction
Update
TODO
Update 2
|
@mattsse should we pull in the Forge integration tests for compilation in ethers-solc perhaps? |
debugging on patched foundry rn Also, currently we're storing absolute paths in the cache file, we can store them relatively, however it doesn't really matter since this should be always kept locally, so I guess absolute paths are fine. |
2 tasks
This was referenced Feb 2, 2022
gakonst
reviewed
Feb 3, 2022
Just a doctest failing |
Update
manual testing indicates, that this appears to finally resolve the spells-mainnet cache bug
BEFORE MERGE
|
OK let's go - pray |
This was referenced Feb 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Close #784
Close #727
Solution
PR Checklist