Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test on CI #658

Closed
2 tasks done
gakonst opened this issue Feb 2, 2022 · 2 comments
Closed
2 tasks done

Flaky test on CI #658

gakonst opened this issue Feb 2, 2022 · 2 comments
Labels
T-bug Type: bug

Comments

@gakonst
Copy link
Member

gakonst commented Feb 2, 2022

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.1.0 (8d84701 2022-02-01T00:34:27.479773+00:00)

What command(s) is the bug in?

forge test

Operating System

Linux

Describe the bug

There's a flaky test on CI
telegram-cloud-photo-size-2-5463169594622591722-y

The println makes me believe the issue is during the svm installation step here, which proceeds to call svm::install.

I think the offending code is either the std::io::copy or the std::fs::File::create above it

@MATTSE mentioned that if gakonst/ethers-rs#802 doesn't address this, we should consider using a lockfile, given that our existing mutexes in ethers-solc seem to not be getting hit

@gakonst gakonst added the T-bug Type: bug label Feb 2, 2022
@onbjerg
Copy link
Member

onbjerg commented Feb 2, 2022

Dupe of #442?

@gakonst
Copy link
Member Author

gakonst commented Feb 2, 2022

Oops - yes.

@gakonst gakonst closed this as completed Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
None yet
Development

No branches or pull requests

2 participants