Fix #427 #464
Fix #427 #464
Conversation
|
I confirmed it works.
|
|
Thanks @Rokt33r, looks great! I'll review more closely tomorrow. Apologies for the delay. |
| @@ -0,0 +1,3 @@ | |||
| { | |||
There was a problem hiding this comment.
can you call this directory something like arrow-function-in-constructor rather than issue-427? Also, we could probably use a few more test fixtures, see what we have for class properties.
I'd also like at least one AppContainer test, since those are more integration-level tests that verify that RHL works, not just the Babel plugin. Here's a reference example
There was a problem hiding this comment.
I'll do gladly. But, I think I can do after the 2nd week of the next month.(I have to finish my graduate thesis.) Could you wait about 3 weeks?
There was a problem hiding this comment.
No problem! Take your time.
|
Done! Please review this again. @calesce |
|
Please merge :( |
|
@calesce It is ok to merge it? |
|
Yep, sorry for the delay, I burned out hard maintaining this project 😄 I only had issues with the file structure but the rest looked fine 👍 |
|
❤️ |
I fixed #427 .
This PR must be reviewed. I'm also going to test this fork by my new project.