Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-hot-loader@v3 breaks babel-plugins #660

Closed
orpheus opened this issue Oct 11, 2017 · 5 comments
Closed

react-hot-loader@v3 breaks babel-plugins #660

orpheus opened this issue Oct 11, 2017 · 5 comments
Labels

Comments

@orpheus
Copy link

orpheus commented Oct 11, 2017

Upgrading to "react-hot-loader": "v3.0.0" is causing conflict with other babel-plugins.

It was working fine until I installed babel-preset-stage-2 and added it to my .babelrc

npm install --save-dev babel-preset-stage-2

&&

{
  "presets": ["env", "react", "stage-2"],
  "plugins": ["react-hot-loader/babel"]
}

After I added "stage-2" to my presets and tried to start my server, I received this error:

ReferenceError: Unknown plugin "react-hot-loader/babel"

Downgrading react-hot-loader back to v3.0.0-beta.7 fixed the issue and now I can use the stage-2 preset along with react-hot-loader.

I also tried installing babel-plugin-transform-class-properties and adding it to my plugins (in stead of the babel preset) and received the same error

@drcmda
Copy link

drcmda commented Oct 11, 2017

Not sure if related but updating to 3.0.0 from beta7 crashes my app as well. I have tried to track it down and it seems to complain about one of my classes, but it's hard to tell what's going on. Going back to beta7 or removing react-hot-loader immediately makes it work again.

screen shot 2017-10-11 at 09 59 05

@gregberge
Copy link
Collaborator

@drcmda it is an other bug related to #464, can you please fill a new issue?

@gregberge
Copy link
Collaborator

@drcmda will do it

@drcmda
Copy link

drcmda commented Oct 11, 2017

@neoziro saw it too late, thanks for everything!

@gregberge
Copy link
Collaborator

Closed as duplicate of #662, by the way it is fixed in next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants