Travis: Make Selenium use Marionette instead of the add-on based driver #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanLorenzo
changed the title
| @@ -38,7 +38,7 @@ | |||
| "node-ssdp": "^2.7.0", | |||
| "path": "^0.12.7", | |||
| "raw-body": "^2.1.6", | |||
| "selenium-webdriver": "2.53.1", | |||
| "selenium-webdriver": "https://github.com/JohanLorenzo/selenium/releases/download/2.54.0-dev/selenium-webdriver-2.54.0-dev.tgz", | |||
There was a problem hiding this comment.
I wish I could add a comment, but JSON doesn't allow it. This is a workaround until SeleniumHQ/selenium#2137 lands in master and a new version is released on npm (likely 2.54)
| capabilities.set('marionette', true); | ||
| const driverBuilder = new webdriver.Builder().withCapabilities(capabilities); | ||
|
|
||
| console.log(driverBuilder.getCapabilities()); |
There was a problem hiding this comment.
Nit: Remove this line
|
Build against Firefox 47 is green. So is Firefox 46 (that version supports both Marionette and the add-on driver). r? @npark-mozilla |
|
looks good to me, hopefully when this is merged, it's still working for me locally as well. r+ |
|
Actually, I rolled back my rust and ran this, and got following error on the first time I ran it, but the test is consistently passing after that, if this is caused by my setup, please ignore.
|
|
@npark-mozilla This error should have been worked around by this selenium client. Does the error occur after Edit: I just pushed an unbitrot revision. Nothing related to that particular failure |
Firefox 46 is the first version allowing Selenium to use Marionette
|
We could merge this, right? EDIT: or right, r+. I think above error was caused by me not running npm install beforehand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current beta version of Firefox break the Selenium tests. This can be reproducible locally. It'll impact our tests once 47 reaches release.
From the Selenium server logs, the installation of the addon in Firefox is not supported anymore. The fix is to make Selenium plug into Marionette server.