[Blocked] Selenium tests: Use Marionette instead of add-on based driver #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanLorenzo
added a commit
that referenced
this pull request
Jun 3, 2016
In case #161 doesn't make master before Firefox 47 is out.
JohanLorenzo
added a commit
that referenced
this pull request
Jun 3, 2016
In case #161 doesn't make master before Firefox 47 is out.
|
The issue related to window.foxbox being undefined is a bug in GeckoDriver. It reached aurora a couple of days ago and will be in beta tomorrow. |
Follow up fxbox/foxbox#489 Content: * Use of manually generated Firefox Profile. This one contains HTTPS exceptions for https://{localhost,127.0.0.1}:{3000,4455,8000} * Gulp installs a patched version of Gecko driver that allows to give profile when Firefox is started. Thill will be removed once 0.8.0 is out. * Npm installs a patched version of selenium client which also allows to use Firefox profile. This will be removed once 2.54 is out * Travis: g++ version is now 4.8, in order to compile C++11 node libraries * Mocha library is changed to gulp-spawn-mocha. The older one had unexpected troubles with inheritence of Map. * loginSuccess waits until promises are resolved.
This reverts commit ba34e89.
Firefox can start with a 4+MB profile in time
This reverts commit a837f69.
|
Blocked by #174 Based on the previous commits, you can see some flakiness in the tests. I don't think it's related to GeckoDriver, but more to the implementation of SW in Firefox. Two reasons making me considering this option: this can be repro'd manually and Firefox bumped from 45 to 48. |
JohanLorenzo
changed the title
|
There hasn't been any activity on this PR for more than 2 years. Although, I see some fxbox repos still have some activity. I'm closing this PR for the sake of cleanup. Please reopen if you think it still has some use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up fxbox/foxbox#489