Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing to cad_to_h5m and graveyard removal #282

Merged
merged 21 commits into from
Dec 31, 2022
Merged

changing to cad_to_h5m and graveyard removal #282

merged 21 commits into from
Dec 31, 2022

Conversation

shimwell
Copy link
Member

graveyard no longer needed as bounding surface is automated in openmc openmc-dev/openmc#2118

Also making use of cad-to-h5m which is simpler than the current method of producing DAGMC h5m files from cad

@codecov
Copy link

codecov bot commented Dec 31, 2022

Codecov Report

Merging #282 (cf9994e) into main (15f7166) will increase coverage by 0.19%.
The diff coverage is 89.18%.

❗ Current head cf9994e differs from pull request most recent head ed243c2. Consider uploading reports for the commit ed243c2 to get more accurate results

@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
+ Coverage   96.30%   96.50%   +0.19%     
==========================================
  Files          82       82              
  Lines        5524     5405     -119     
==========================================
- Hits         5320     5216     -104     
+ Misses        204      189      -15     
Impacted Files Coverage Δ
src/paramak/shape.py 96.83% <76.92%> (-0.24%) ⬇️
src/paramak/reactor.py 85.11% <94.11%> (+5.19%) ⬆️
src/paramak/__init__.py 94.56% <100.00%> (+0.05%) ⬆️
...tric_components/toroidal_field_coil_princeton_d.py 100.00% <100.00%> (ø)
src/paramak/utils.py 90.85% <100.00%> (-1.87%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shimwell shimwell merged commit e5f7137 into main Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant