-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing graveyards #281
Removing graveyards #281
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #281 +/- ##
===========================================
+ Coverage 96.30% 96.48% +0.17%
===========================================
Files 82 82
Lines 5524 5405 -119
===========================================
- Hits 5320 5215 -105
+ Misses 204 190 -14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
It looks like some of the numpy/scipy code used in the We had a DeprecationWarning message for a while (scipy 1.8.0 and numpy 1.22.2)
but now the code is failing (scipy 1.9.3 and numpy 1.24.1)
|
Looks like the scipy odeint function no longer accepts numpy arrays of a particular shape, I think this is the line of code causing pytest tests/tests_units/test_parametric_components/test_test_tf_coil_casing.py to fail
|
Proposed changes
graveyards are now automatic in openmc so we can remove a nice amount of code 🎉