Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding circlar ports with flange gap option #215

Merged
merged 8 commits into from
Mar 20, 2022

Conversation

shimwell
Copy link
Member

Proposed changes

Adds a circular port parametric component that is a pipe with a flange. An svg image was made with and can be uploaded to the docs later

component.export_svg('/home/jshimwell/paramak/port.svg', projectionDir=(-0.1, -0.45, 1))

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@shimwell shimwell mentioned this pull request Mar 19, 2022
8 tasks
@codecov
Copy link

codecov bot commented Mar 19, 2022

Codecov Report

Merging #215 (b7aa664) into develop (d3312da) will increase coverage by 0.49%.
The diff coverage is 90.90%.

❗ Current head b7aa664 differs from pull request most recent head 37e4488. Consider uploading reports for the commit 37e4488 to get more accurate results

@@             Coverage Diff             @@
##           develop     #215      +/-   ##
===========================================
+ Coverage    95.60%   96.10%   +0.49%     
===========================================
  Files           79       80       +1     
  Lines         5281     5336      +55     
===========================================
+ Hits          5049     5128      +79     
+ Misses         232      208      -24     
Impacted Files Coverage Δ
paramak/parametric_components/circular_port.py 90.74% <90.74%> (ø)
paramak/__init__.py 94.38% <100.00%> (+0.06%) ⬆️
paramak/shape.py 95.21% <0.00%> (+1.88%) ⬆️
paramak/utils.py 94.89% <0.00%> (+2.91%) ⬆️
paramak/reactor.py 77.44% <0.00%> (+3.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3312da...37e4488. Read the comment docs.

@shimwell shimwell merged commit d0cc1ab into develop Mar 20, 2022
@shimwell shimwell deleted the adding_circlar_ports_try_3 branch March 20, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant