Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added first draft of circular ports #213

Closed
wants to merge 5 commits into from

Conversation

shimwell
Copy link
Member

Proposed changes

Adds a circular port parametric component that is a pipe with a flange. An svg image was made with and can be uploaded to the docs later

component.export_svg('/home/jshimwell/paramak/port.svg', projectionDir=(-0.1, -0.45, 1))

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #213 (a5f830c) into develop (96f3eb1) will decrease coverage by 0.74%.
The diff coverage is 78.73%.

❗ Current head a5f830c differs from pull request most recent head 5ee941c. Consider uploading reports for the commit 5ee941c to get more accurate results

@@             Coverage Diff             @@
##           develop     #213      +/-   ##
===========================================
- Coverage    95.64%   94.90%   -0.75%     
===========================================
  Files           79       80       +1     
  Lines         5263     5314      +51     
===========================================
+ Hits          5034     5043       +9     
- Misses         229      271      +42     
Impacted Files Coverage Δ
...amak/parametric_components/blanket_cutters_star.py 100.00% <ø> (ø)
paramak/parametric_components/extrude_rectangle.py 100.00% <ø> (ø)
...ramak/parametric_components/poloidal_field_coil.py 100.00% <ø> (ø)
...tric_components/poloidal_field_coil_case_set_fc.py 97.10% <0.00%> (ø)
paramak/parametric_components/vacuum_vessel.py 90.62% <0.00%> (ø)
paramak/parametric_components/circular_port.py 16.00% <16.00%> (ø)
...mak/parametric_components/capsule_vacuum_vessel.py 86.79% <33.33%> (ø)
paramak/reactor.py 74.07% <42.85%> (ø)
...k/parametric_components/vacuum_vessel_inner_leg.py 89.06% <50.00%> (ø)
...ic_components/toroidal_field_coil_round_corners.py 93.88% <87.50%> (ø)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f3eb1...5ee941c. Read the comment docs.

@shimwell
Copy link
Member Author

circularport drawio

1 similar comment
@shimwell
Copy link
Member Author

circularport drawio

@shimwell
Copy link
Member Author

closed in favor of #215

@shimwell shimwell closed this Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant