Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #15

Merged
merged 17 commits into from
Jul 6, 2021
Merged

Develop #15

merged 17 commits into from
Jul 6, 2021

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Jul 5, 2021

Proposed changes

Update to the docs to include latest 3d models
use of pypi token instead of username and password
removal of neutronics examples (similar examples are in the paramak-neutronics repo)
addition of BlanketFPPoloidalSegments based example

the makewatertight test might still be failing but there are plans to do this in a different way

Thank to @Blitan @mateczentye and @billingsley-john for the additions

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@shimwell shimwell merged commit 24ec41c into main Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants