Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mate docs 3 drenders #13

Merged
merged 11 commits into from
Jul 5, 2021
Merged

Mate docs 3 drenders #13

merged 11 commits into from
Jul 5, 2021

Conversation

mateczentye
Copy link
Collaborator

Proposed changes

Added 3D renders of examples

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link
Collaborator

@billingsley-john billingsley-john left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like some great additions!

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@0e73db2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #13   +/-   ##
==========================================
  Coverage           ?   97.53%           
==========================================
  Files              ?       72           
  Lines              ?     4752           
  Branches           ?        0           
==========================================
  Hits               ?     4635           
  Misses             ?      117           
  Partials           ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e73db2...350441d. Read the comment docs.

@shimwell
Copy link
Member

shimwell commented Jul 5, 2021

Thanks for the contribution

@shimwell shimwell merged commit 37e1a79 into develop Jul 5, 2021
@shimwell shimwell deleted the mate_docs_3Drenders branch July 5, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants