-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addng docker layer caching, pep8 changes, mypy changes #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mak into isort_and_mypy_tidyup
Isort and mypy tidyup
Replacing auto pep8
…ramak into adding_pyrender_example
Docker layer caching
Adding pyrender example
shimwell
changed the title
Develop
Addng docker layer caching, pep8 changes, mypy changes
Nov 28, 2021
Looks like I have a few suggestions from codiga to fix in the new render examples |
Codecov Report
@@ Coverage Diff @@
## main #137 +/- ##
==========================================
+ Coverage 97.56% 97.73% +0.17%
==========================================
Files 76 76
Lines 4717 4689 -28
==========================================
- Hits 4602 4583 -19
+ Misses 115 106 -9
Continue to review full report at Codecov.
|
add another test suite add parametric rectors tests try test splitting add store tests results parallelism for parametric components tests
CircleCI pipeline optimisations
updated to include everyone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds docker layer caching to the building yml for the docker images. This should speed up the docker images and make them easier to build locally. the second stage uses FROM and this makes use of a cache instead of downloading from the ghcr.
MyPy was used to fix a few type errors in the type hinting
Pep has been improved by replacing the autopep with black.
Also added some examples to produce render image s of reactors
Mainly refactoring
Types of changes
Checklist