Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addng docker layer caching, pep8 changes, mypy changes #137

Merged
merged 37 commits into from
Dec 1, 2021
Merged

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Nov 28, 2021

Proposed changes

This PR adds docker layer caching to the building yml for the docker images. This should speed up the docker images and make them easier to build locally. the second stage uses FROM and this makes use of a cache instead of downloading from the ghcr.

MyPy was used to fix a few type errors in the type hinting

Pep has been improved by replacing the autopep with black.

Also added some examples to produce render image s of reactors

Mainly refactoring

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@shimwell shimwell changed the title Develop Addng docker layer caching, pep8 changes, mypy changes Nov 28, 2021
@shimwell
Copy link
Member Author

Looks like I have a few suggestions from codiga to fix in the new render examples

@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

Merging #137 (65a36ef) into main (bee4f04) will increase coverage by 0.17%.
The diff coverage is 97.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   97.56%   97.73%   +0.17%     
==========================================
  Files          76       76              
  Lines        4717     4689      -28     
==========================================
- Hits         4602     4583      -19     
+ Misses        115      106       -9     
Impacted Files Coverage Δ
...ric_components/blanket_constant_thickness_arc_v.py 100.00% <ø> (ø)
...mak/parametric_components/port_cutters_circular.py 100.00% <ø> (ø)
...ametric_reactors/single_null_submersion_reactor.py 100.00% <ø> (ø)
paramak/parametric_shapes/extruded_spline_shape.py 100.00% <ø> (ø)
...ramak/parametric_shapes/extruded_straight_shape.py 100.00% <ø> (ø)
paramak/parametric_shapes/rotate_spline_shape.py 100.00% <ø> (ø)
paramak/parametric_shapes/rotate_straight_shape.py 100.00% <ø> (ø)
paramak/parametric_shapes/sweep_spline_shape.py 100.00% <ø> (ø)
paramak/parametric_components/vacuum_vessel.py 90.62% <50.00%> (ø)
...k/parametric_components/vacuum_vessel_inner_leg.py 89.23% <72.72%> (ø)
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bee4f04...65a36ef. Read the comment docs.

@shimwell shimwell merged commit 7bb5365 into main Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant