Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isort and mypy tidyup #122

Merged
merged 6 commits into from
Oct 19, 2021
Merged

Isort and mypy tidyup #122

merged 6 commits into from
Oct 19, 2021

Conversation

shimwell
Copy link
Member

Proposed changes

Using python packages isort and mypy to tidy up the import statements and the type hinting. This PR reduces the number of mypy warnings originating from the paramak source code

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #122 (4180323) into develop (c2a595c) will increase coverage by 0.17%.
The diff coverage is 98.41%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #122      +/-   ##
===========================================
+ Coverage    97.57%   97.75%   +0.17%     
===========================================
  Files           76       76              
  Lines         4703     4675      -28     
===========================================
- Hits          4589     4570      -19     
+ Misses         114      105       -9     
Impacted Files Coverage Δ
...ric_components/blanket_constant_thickness_arc_v.py 100.00% <ø> (ø)
.../parametric_components/blanket_cutter_parallels.py 100.00% <ø> (ø)
...ak/parametric_components/center_column_cylinder.py 100.00% <ø> (ø)
...tric_components/center_column_flat_top_circular.py 100.00% <ø> (ø)
...ric_components/center_column_flat_top_hyperbola.py 100.00% <ø> (ø)
...k/parametric_components/center_column_hyperbola.py 100.00% <ø> (ø)
...etric_components/center_column_plasma_dependant.py 100.00% <ø> (ø)
...rametric_components/coolant_channel_ring_curved.py 100.00% <ø> (ø)
...metric_components/coolant_channel_ring_straight.py 100.00% <ø> (ø)
paramak/parametric_components/cutting_wedge.py 100.00% <ø> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2a595c...4180323. Read the comment docs.

@shimwell shimwell merged commit 4f720ec into develop Oct 19, 2021
@shimwell shimwell deleted the isort_and_mypy_tidyup branch October 19, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant