Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS 13 SystemFont Changes + Previous System Font Issues #1291

Merged
merged 1 commit into from
Sep 20, 2019
Merged

iOS 13 SystemFont Changes + Previous System Font Issues #1291

merged 1 commit into from
Sep 20, 2019

Conversation

AndrewEQ
Copy link
Contributor

  • added iOS13 way of doing SystemFont
  • fixed older system font issues with font weight/style
  • added reasonable fallbacks for missing font weights for older system font way

This PR contains:

  • Changelog
  • Documentation
  • Tests

@AndrewEQ AndrewEQ changed the title iOS13 SystemFont Changes + Previous System Font Issues iOS 13 SystemFont Changes + Previous System Font Issues Aug 31, 2019
@AndrewEQ
Copy link
Contributor Author

This PR is also failing the same way as #1290, because the CI is not using latest XCode which includes iOS13 frameworks.

@AndrewEQ
Copy link
Contributor Author

ok, updated with iOS 13 checks, if it passes, will probably still need someone to test on XCode version less than 11

@AndrewEQ
Copy link
Contributor Author

oh, the test would be simple like being able to build an iOS app and the default font still works as well as a custom defined one.

@mortend
Copy link
Member

mortend commented Sep 19, 2019

I can test this on Xcode 9.4 and iOS 12.4 later tonight.

mortend
mortend requested changes Sep 20, 2019
View reviewed changes
Copy link
Member

@mortend mortend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code needs to be cleaned up a bit more. ;)

@AndrewEQ
Copy link
Contributor Author

Ok, sorted.

mortend
mortend requested changes Sep 20, 2019
View reviewed changes
Copy link
Member

@mortend mortend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's getting there, but I'm a bit confused about font sizes and nitpicking some more about code-style.

Source/Fuse.Common/Internal/SystemFont.uno Outdated Show resolved Hide resolved
Source/Fuse.Common/Internal/iOSSystemFont.uno Show resolved Hide resolved
Source/Fuse.Common/Internal/iOSSystemFont.uno Outdated Show resolved Hide resolved
Source/Fuse.Common/Internal/iOSSystemFont.uno Outdated Show resolved Hide resolved
Source/Fuse.Common/Internal/iOSSystemFont.uno Outdated Show resolved Hide resolved
@AndrewEQ
Copy link
Contributor Author

Sorted.

@AndrewEQ
iOS 13 SystemFont Changes + Previous System Font Issues
b77183e 
- added iOS13 way of doing SystemFont
- fixed older system font issues with font weight/style
- added reasonable fallbacks for missing font weights for older system font way
- added fallbacks for missing desktop font styles
mortend
mortend approved these changes Sep 20, 2019
View reviewed changes
Copy link
Member

@mortend mortend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now. Good stuff!

@mortend mortend merged commit ab2048f into fuse-open:master Sep 20, 2019
@AndrewEQ
Copy link
Contributor Author

Shweet!

@ichan-mb ichan-mb mentioned this pull request Sep 22, 2019
Closed
@ichan-mb ichan-mb mentioned this pull request Jan 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortend mortend mortend approved these changes

@ckarmy ckarmy Awaiting requested review from ckarmy

@LuisRodriguezLD LuisRodriguezLD Awaiting requested review from LuisRodriguezLD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewEQ @mortend