Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 13 Font bugs #1285

Closed
ichan-mb opened this issue Aug 3, 2019 · 4 comments
Closed

iOS 13 Font bugs #1285

ichan-mb opened this issue Aug 3, 2019 · 4 comments

Comments

@ichan-mb
Copy link
Member

ichan-mb commented Aug 3, 2019

Describe the bug
Default fonts (using system font) on iOS 13 look terrible, it's bigger and spacing between character is so wide and space character is also wide. I assume Fuse doesn't pick up default system font family or default system font path

To Reproduce
Compile this code on Xcode 11 and targeting iOS 13

<App>
	<ClientPanel>
		<StackPanel Alignment="CenterLeft" ItemSpacing="5">
			<Text Value="This is sample text" Font="Thin"/>
			<Text Value="This is sample text" Font="Light"/>
			<Text Value="This is sample text" Font="Regular"/>
			<Text Value="This is sample text" Font="Medium"/>
			<Text Value="This is sample text" Font="Bold"/>
			<Text Value="This is sample text" Font="ThinItalic"/>
			<Text Value="This is sample text" Font="LightItalic"/>
			<Text Value="This is sample text" Font="Italic"/>
			<Text Value="This is sample text" Font="MediumItalic"/>
			<Text Value="This is sample text" Font="BoldItalic"/>
		</StackPanel>
	</ClientPanel>
</App>

Expected behavior
Displaying default system font (San Fransisco Font) with correct weight and styles

Screenshots
https://drive.google.com/file/d/1bUOR2wJ98wxbX35tvTRzBrfErdhXR0bV/view?usp=sharing

Smartphone (please complete the following information):

  • Device: iPhone Xr & Simulator
  • OS: iOS 13
@kusma
Copy link
Contributor

kusma commented Aug 4, 2019

Yeah, looks like somehow a monospace font gets picked up instead. That's odd, and will require some debugging on an iOS device. Sadly, I don't have access to a mac or iOS device any longer...

@AndrewEQ
Copy link
Contributor

Hey guys,

I noticed this when I switched between fuselibs and used uno doctor:

/fuselibs/Source/Fuse.Controls.Primitives/TextControls/FallbackTextRenderer/DefaultTextRenderer.uno(164.78): W4139: Uno.Content.Fonts.CharacterSets is obsolete
/fuselibs/Source/Fuse.Controls.Primitives/TextControls/FallbackTextRenderer/DefaultTextRenderer.uno(162.22): W4139: Uno.Content.Fonts.BitmapFont is obsolete
/fuselibs/Source/Fuse.Controls.Primitives/TextControls/FallbackTextRenderer/DefaultTextRenderer.uno(165.18): W4139: Uno.Content.Fonts.BitmapFont is obsolete
/fuselibs/Source/Fuse.Controls.Primitives/TextControls/FallbackTextRenderer/DefaultTextRenderer.uno(177.16): W4139: Uno.Content.Fonts.TextRenderer is obsolete
/fuselibs/Source/Fuse.Controls.Primitives/TextControls/FallbackTextRenderer/DefaultTextRenderer.uno(177.66): W4139: Uno.Content.Fonts.SpriteFontShader is obsolete
/fuselibs/Source/Fuse.Controls.Primitives/TextControls/FallbackTextRenderer/DefaultTextRenderer.uno(178.26): W4139: Uno.Content.Fonts.TextTransform is obsolete
/fuselibs/Source/Fuse.Controls.Primitives/TextControls/FallbackTextRenderer/DefaultTextRenderer.uno(63.20): W4139: Uno.Content.Fonts.BitmapFont is obsolete
/fuselibs/Source/Fuse.Controls.Primitives/TextControls/FallbackTextRenderer/DefaultTextRenderer.uno(51.18): W4139: Uno.Content.Fonts.TextRenderer is obsolete
/fuselibs/Source/Fuse.Controls.Primitives/TextControls/FallbackTextRenderer/DefaultTextRenderer.uno(51.74): W4139: Uno.Content.Fonts.SpriteFontShader is obsolete
/fuselibs/Source/Fuse.Controls.Primitives/TextControls/FallbackTextRenderer/DefaultTextRenderer.uno(52.28): W4139: Uno.Content.Fonts.TextTransform is obsolete
/fuselibs/Source/Fuse.Controls.Primitives/TextControls/FallbackTextRenderer/DefaultTextRenderer.uno(182.8): W4139: Uno.Content.Fonts.TextTransform is obsolete
/fuselibs/Source/Fuse.Controls.Primitives/TextControls/FallbackTextRenderer/TextRenderer.uno(45.21): W4139: 'Uno.Content.Fonts.FontFace.Load(string,byte[],int,int)' is obsolete

Had a look for Uno.Content.Fonts.CharacterSets and found this: https://github.com/fuse-open/uno/blob/8582e76cd9de40a8568ca757837cdc64211c9403/lib/UnoCore/Source/Uno/Content/Fonts/FontFaceHelpers.uno

Could this be the cause @mortend? 😄

@AndrewEQ
Copy link
Contributor

...or not, I'm looking into another hunch... 😸

@ichan-mb
Copy link
Member Author

fixed #1291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants