-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rate limits #13
Open
Cmrickels
wants to merge
2
commits into
fullcontact:master
Choose a base branch
from
Cmrickels:rate-limits
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rate limits #13
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,65 +60,65 @@ public function __construct($api_key) | |
$this->_apiKey = $api_key; | ||
} | ||
|
||
/** | ||
* This sets the webhook url for all requests made for this service | ||
* instance. To unset, just use setWebhookUrl(null). | ||
* | ||
* @author David Boskovic <[email protected]> @dboskovic | ||
* @param string $url | ||
* @param string $id | ||
* @return object | ||
*/ | ||
public function setWebhookUrl($url, $id = null) { | ||
$this->_webhookUrl = $url; | ||
$this->_webhookId = $id; | ||
return $this; | ||
} | ||
|
||
/** | ||
* This is a pretty close copy of my work on the Contactually PHP library | ||
* available here: http://github.com/caseysoftware/contactually-php | ||
* | ||
* @author Keith Casey <[email protected]> | ||
* @author David Boskovic <[email protected]> @dboskovic | ||
* @param array $params | ||
* @return object | ||
* @throws Services_FullContact_Exception_NotImplemented | ||
*/ | ||
|
||
protected function _execute($params = array()) | ||
{ | ||
if(!in_array($params['method'], $this->_supportedMethods)){ | ||
throw new Services_FullContact_Exception_NotImplemented(__CLASS__ . | ||
" does not support the [" . $params['method'] . "] method"); | ||
" does not support the [" . $params['method'] . "] method"); | ||
} | ||
|
||
$params['apiKey'] = $this->_apiKey; | ||
|
||
if($this->_webhookUrl) { | ||
$params['webhookUrl'] = $this->_webhookUrl; | ||
} | ||
|
||
if($this->_webhookId) { | ||
$params['webhookId'] = $this->_webhookId; | ||
} | ||
|
||
|
||
$fullUrl = $this->_baseUri . $this->_version . $this->_resourceUri . | ||
'?' . http_build_query($params); | ||
'?' . http_build_query($params); | ||
|
||
//open connection | ||
$connection = curl_init($fullUrl); | ||
curl_setopt($connection, CURLOPT_RETURNTRANSFER, 1); | ||
curl_setopt($connection, CURLOPT_USERAGENT, self::USER_AGENT); | ||
curl_setopt($connection, CURLOPT_HEADER, 1); | ||
|
||
//execute request | ||
$this->response_json = curl_exec($connection); | ||
$this->response_code = curl_getinfo($connection, CURLINFO_HTTP_CODE); | ||
$this->response_obj = json_decode($this->response_json); | ||
|
||
preg_match_all('/X-Rate-Limit-.{0,}/',$this->response_json, $out, PREG_PATTERN_ORDER); | ||
preg_match("/\d{1,}/",$out[0][0],$limit); | ||
preg_match("/\d{1,}/",$out[0][1],$remaining); | ||
preg_match("/\d{1,}/",$out[0][2],$reset); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is currently dependent on the output order, is it not? This method of getting the headers is tolerable, but I'd prefer to see something more robust/explicit with regard to the header names and order. |
||
|
||
$pos = strpos($this->response_json, '{'); | ||
$response = substr($this->response_json, $pos); | ||
|
||
$this->response_obj = json_decode($response); | ||
$this->response_obj->limit = $limit[0]; | ||
$this->response_obj->remaining_calls = $remaining[0]; | ||
$this->response_obj->remaining_seconds = $reset[0]; | ||
|
||
if ('403' == $this->response_code) { | ||
throw new Services_FullContact_Exception_NoCredit($this->response_obj->message); | ||
} | ||
|
||
return $this->response_obj; | ||
} | ||
|
||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This removal block should be reverted. We still want to expose the ability to set the webhook parameters.