Rate limits #13
Open
Rate limits #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 10, 2016 16:42
johkelly
suggested changes
Jan 16, 2017
| return $this; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
This removal block should be reverted. We still want to expose the ability to set the webhook parameters.
| preg_match_all('/X-Rate-Limit-.{0,}/',$this->response_json, $out, PREG_PATTERN_ORDER); | ||
| preg_match("/\d{1,}/",$out[0][0],$limit); | ||
| preg_match("/\d{1,}/",$out[0][1],$remaining); | ||
| preg_match("/\d{1,}/",$out[0][2],$reset); |
There was a problem hiding this comment.
This is currently dependent on the output order, is it not? This method of getting the headers is tolerable, but I'd prefer to see something more robust/explicit with regard to the header names and order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rate Limit Headers
Added a fix to return the rate limit headers as properties with the response object. The properties are 'limit', 'remaining_calls', and 'remaining_seconds'. Those names can be changed very easily on line 112, 113, and 114 according to preference.