Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the core logic of modal sheet and fixes the following long standing issues:
Breaking changes
Removed
SheetDismissible
and addedbool swipeDismissible
as a replacement forModalSheetRoute
and similar classes likeModalSheetPage
andCupertinoModalSheetRoute
. See the migration guide for more details.Internal changes
SheetGestureTamper
andTamperSheetGesture
.ModalSheetRouteMixin
to use theTamperSheetGesture
widget to handle drag gestures on a modal sheet.Screenshots
Before:
RocketSim_Recording_iPhone_15_6.1_2024-05-26_16.27.05.mp4
After:
RocketSim_Recording_iPhone_15_6.1_2024-05-26_16.30.59.mp4