Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve modal sheet UX #138

Merged
merged 12 commits into from
May 26, 2024
Merged

Improve modal sheet UX #138

merged 12 commits into from
May 26, 2024

Conversation

fujidaiti
Copy link
Owner

@fujidaiti fujidaiti commented May 23, 2024

This PR reworks the core logic of modal sheet and fixes the following long standing issues:

Breaking changes

Removed SheetDismissible and added bool swipeDismissible as a replacement for ModalSheetRoute and similar classes like ModalSheetPage and CupertinoModalSheetRoute. See the migration guide for more details.

Internal changes

  • Added SheetGestureTamper and TamperSheetGesture.
  • Modified ModalSheetRouteMixin to use the TamperSheetGesture widget to handle drag gestures on a modal sheet.

Screenshots

Before:

RocketSim_Recording_iPhone_15_6.1_2024-05-26_16.27.05.mp4

After:

RocketSim_Recording_iPhone_15_6.1_2024-05-26_16.30.59.mp4

@fujidaiti fujidaiti self-assigned this May 23, 2024
@fujidaiti fujidaiti marked this pull request as ready for review May 26, 2024 07:33
@fujidaiti fujidaiti merged commit d600a6c into main May 26, 2024
7 checks passed
@fujidaiti fujidaiti deleted the refactor-modal branch May 26, 2024 07:33
@naamapps
Copy link

PERFECT!!
Nicely done @fujidaiti 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment