Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scala-xml 2.x with Scala 2.13+ to fix conflics with sbt-scoverage #1098

Closed
wants to merge 1 commit into from
Closed

Use scala-xml 2.x with Scala 2.13+ to fix conflics with sbt-scoverage #1098

wants to merge 1 commit into from

Conversation

guizmaii
Copy link

@guizmaii guizmaii changed the title Use scala-xml 2.x with Scala 2.13+ to fix conflics with sbt-scoverage [WIP] Use scala-xml 2.x with Scala 2.13+ to fix conflics with sbt-scoverage Jun 26, 2022
@guizmaii
Copy link
Author

@fthomas Locally, the tests pass on Scala 2.13 with this change

@guizmaii guizmaii changed the title [WIP] Use scala-xml 2.x with Scala 2.13+ to fix conflics with sbt-scoverage Use scala-xml 2.x with Scala 2.13+ to fix conflics with sbt-scoverage Jun 26, 2022
@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #1098 (1edd6a5) into master (80f5cb7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1098   +/-   ##
=======================================
  Coverage   92.58%   92.58%           
=======================================
  Files          63       63           
  Lines         836      836           
  Branches        8       10    +2     
=======================================
  Hits          774      774           
  Misses         62       62           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80f5cb7...1edd6a5. Read the comment docs.

@guizmaii
Copy link
Author

Seeing #1099, I think we don't need my PR anymore. Thanks @fthomas

@guizmaii guizmaii closed this Jun 27, 2022
@guizmaii guizmaii deleted the scalaxml2_2.13 branch June 27, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant