-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to scala-xml 2 #1513
Comments
IIRC there was already an attempt made, but rolled back due to other incompatibilities. |
I suggest you bite this bullet. It's nearly unheard of for the upgrade to actually cause a problem. The major version number bump frightens people, but the removed things were already deprecated and rarely used anyway. |
I don't see any previous upgrade attempt other than #1454 |
Well I did the obvious thing and CI seems fine. #1514 |
Thanks for all the input 😄 I'll merged the PR and will release next week. |
IMHO next time such an major version bump like from scala-xml 1 to 2 should not be done in a patch release... People start a lot to open issues and ask in chats about the whole scala-xml upgrade mess. |
More and more sbt plugins are moving to scala-xml 2, for example now I've been blocked from upgrading sbt-scoverage
See:
scoverage/scalac-scoverage-plugin#488
scoverage/sbt-scoverage#439
fthomas/refined#1098
The text was updated successfully, but these errors were encountered: