Fix #5 by adding 'xerror' and 'stderr' psuedo err_detect options #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If ffmpeg was run, when check_mi.py completes echo for the terminal has been disabled. Instead do not have ffmpeg stdin come from the terminal.
Presumably the --strict_level option should apply to single files as well.
When the identify command fails the stderr output can be useful in diagnosing why it failed, which could be due to a configuratin issue and not a real failure.
On a timeout error the following output has been observed:
Traceback (most recent call last):
File "./check_mi.py", line 475, in <module>
main()
File "./check_mi.py", line 460, in main
print("Waiting other results for too much time, perhaps you have to raise the timeout", e.message)
AttributeError: 'Empty' object has no attribute 'message'
Do not assume that exception objects have a message attribute.
The 'xerror' option adds the '-xerror' option to ffmpeg which causes it to exit early on any corrupt frames. The 'stderr' option causes the ffmpeg_check to fail if there is any error level log messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dependent on PR #19. Really this PR is just the last 2 commits. It also fixes issue #5.
The
xerroroption adds the-xerroroption to ffmpeg which causes it to exit early on any corrupt frames. Thestderroption causes theffmpeg_checkcall to fail if there is any error level log messages.This was implemented as psuedo options to err_detect instead of a new option to have all ffmpeg error handling options go through one option. Also, even though ffmpeg's
-err_detectoption has no effect for me, even on the video files with corruption that I've tried, I've left this capability as it might be working for others.