Improvements #19
Open
Improvements #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If ffmpeg was run, when check_mi.py completes echo for the terminal has been disabled. Instead do not have ffmpeg stdin come from the terminal.
Presumably the --strict_level option should apply to single files as well.
When the identify command fails the stderr output can be useful in diagnosing why it failed, which could be due to a configuratin issue and not a real failure.
On a timeout error the following output has been observed:
Traceback (most recent call last):
File "./check_mi.py", line 475, in <module>
main()
File "./check_mi.py", line 460, in main
print("Waiting other results for too much time, perhaps you have to raise the timeout", e.message)
AttributeError: 'Empty' object has no attribute 'message'
Do not assume that exception objects have a message attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of bug fixes and improvements. Some of these were cherry picked from @aaronkollasch's fork and I added details to some of his commit messages while keeping him as the author. The last commit updates the requirements to dependency versions that currently work for me. I think these changes should be fairly uncontroversial. Also this has been tested with 3.8 and 3.10.