-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry decorator for _call and _get_file #387
Conversation
@martindurant let me know what you think of this as an alternative to #384 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On first look, this all seems reasonable. I have a couple of comments.
Unfortunately, the diff is a little inflated by the formatter changing some lines that were fine previously - perhaps a new version of black
:|
yes, black's behavior when confronted with split lines that could fit into one line has changed. Anyway, I reverted the formatting changes. |
Still passes :) |
Is this ready to be merged? It would also be nice to issue a new PyPI release. |
I think it's good to go. @martindurant let me know if you see remaining issues—I'm happy to address. |
Resolves #383 by retrying both
_get_file
and_call
with a newretry_request
decorator. Differently from #384, this PR leaves internals of_get_file
intact.