Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry decorator for _call and _get_file #387

Merged
merged 11 commits into from
May 5, 2021

Conversation

oliverwm1
Copy link
Contributor

Resolves #383 by retrying both _get_file and _call with a new retry_request decorator. Differently from #384, this PR leaves internals of _get_file intact.

gcsfs/core.py Show resolved Hide resolved
gcsfs/core.py Show resolved Hide resolved
@oliverwm1
Copy link
Contributor Author

@martindurant let me know what you think of this as an alternative to #384

Copy link
Member

@martindurant martindurant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On first look, this all seems reasonable. I have a couple of comments.
Unfortunately, the diff is a little inflated by the formatter changing some lines that were fine previously - perhaps a new version of black :|

gcsfs/retry.py Outdated Show resolved Hide resolved
gcsfs/retry.py Show resolved Hide resolved
@oliverwm1
Copy link
Contributor Author

Unfortunately, the diff is a little inflated by the formatter changing some lines that were fine previously - perhaps a new version of black :|

yes, black's behavior when confronted with split lines that could fit into one line has changed. Anyway, I reverted the formatting changes.

@martindurant
Copy link
Member

I reverted the formatting changes.

Still passes :)

@nbren12
Copy link
Contributor

nbren12 commented May 4, 2021

Is this ready to be merged? It would also be nice to issue a new PyPI release.

@oliverwm1
Copy link
Contributor Author

I think it's good to go. @martindurant let me know if you see remaining issues—I'm happy to address.

@martindurant martindurant merged commit f53b58f into fsspec:main May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_get_file does not use _call, and so does not have any retry logic
3 participants