-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use _call within _get_file to ensure retries #384
Conversation
@isidentical , this is probably also of interest to you |
@martindurant @isidentical thoughts on this? It passes the (skipped) test_get_put tests for me locally, and I've manually called |
I'm pretty sure we need a way to split up the reads and stream to disc, else we risk memory issues. |
Okay. Other idea is to define a retry decorator that we can apply to |
Perhaps you can pass the output file into |
Closing in favor of #387 |
Use
_call
within_get_file
to ensure that the retry logic in that function is exercised. This PR makes a significant change in implementation, since now multiple http requests are made within single_get_file
call (if the file is large) whereas previously a single request was made. Not sure about performance implications (speed, memory usage, reliability).Resolves #383